Consolidate GitHub Actions workflows#113
Merged
Merged
Conversation
Member
nscuro
commented
May 30, 2026
nscuro
commented
- Moves lint jobs into a single workflow.
- Separates building from linting.
- Assigns proper names to all jobs so they're usable in GitHub branch protection rules.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates and clarifies CI responsibilities by separating linting and build checks into dedicated GitHub Actions workflows, and by giving jobs stable names suitable for branch protection rules.
Changes:
- Refactors
lint.ymlinto separate “Docs” and “GitHub Actions” lint jobs. - Removes PR lint/build steps from
deploy.yml, keeping it focused on push/tag deployments. - Introduces a new
build.ymlworkflow to runmake buildon pull requests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/lint.yml | Splits linting into distinct jobs for docs/prose/YAML and for GitHub Actions (zizmor). |
| .github/workflows/deploy.yml | Simplifies deploy workflow by removing PR-only lint/build job; keeps deploy on pushes/tags. |
| .github/workflows/build.yml | Adds a dedicated PR build workflow running make build. |
Comments suppressed due to low confidence (2)
.github/workflows/lint.yml:33
lint-docsrunsactions/checkout, but this workflow setspermissions: {}at the top level, so the job currently has nocontents: readpermission and checkout will fail. Also, compared to the previous PR lint job indeploy.yml, PRs no longer runmake lint-python, which is likely an unintended regression given the PR description about consolidating lint jobs.
.github/workflows/deploy.yml:22on.push.tagspatterns are glob-style, not regex. The current patterns include+, which is treated literally and will not match typical SemVer tags like1.2.3(it would match1+.2+.3+instead), so tag-based deploys likely won’t trigger.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Moves lint jobs into a single workflow. * Separates building from linting. * Assigns proper names to all jobs so they're usable in GitHub branch protection rules. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.